From 6fe885132a9c227c26364fc5428b2d726da7208f Mon Sep 17 00:00:00 2001 From: mitteneer Date: Mon, 7 Jul 2025 16:40:56 -0400 Subject: [PATCH] Do not use peak I only tested it on small datasets, and it wasn't so bad, but with my whole LastFM dataset, it is very bad --- src/app/views/albums.zig | 4 ++-- src/app/views/albums/get.zmpl | 1 - src/app/views/artists.zig | 4 ++-- src/app/views/artists/get.zmpl | 1 - src/app/views/songs.zig | 4 ++-- src/app/views/songs/get.zmpl | 1 - 6 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/app/views/albums.zig b/src/app/views/albums.zig index 5f3e0e4..1a3c799 100644 --- a/src/app/views/albums.zig +++ b/src/app/views/albums.zig @@ -55,8 +55,8 @@ pub fn get(id: []const u8, request: *jetzig.Request) !jetzig.View { const ratings = try queries.entityQueryResult(request, comptime queries.loadQuery(.song, .get_ratings), .{id_int}); try root.put("reviews", ratings); - const peak = try queries.entityQueryResult(request, comptime queries.loadQuery(.album, .peak), .{id_int}); - try root.put("peak", peak); + //const peak = try queries.entityQueryResult(request, comptime queries.loadQuery(.album, .peak), .{id_int}); + //try root.put("peak", peak); return request.render(.ok); } diff --git a/src/app/views/albums/get.zmpl b/src/app/views/albums/get.zmpl index d62af1c..7f40eb5 100644 --- a/src/app/views/albums/get.zmpl +++ b/src/app/views/albums/get.zmpl @@ -31,7 +31,6 @@ @else
{{.album.scrobbles}} scrobbles ({{.album.rank}} place)
@end -
All-time peak: {{.peak.rank}} ({{.peak.date}})
{{.album.song_num}} songs
@partial partials/firstlast_listens(firstlast: .firstlast)

Yearly Performance

diff --git a/src/app/views/artists.zig b/src/app/views/artists.zig index 540ccd3..3136def 100644 --- a/src/app/views/artists.zig +++ b/src/app/views/artists.zig @@ -54,8 +54,8 @@ pub fn get(id: []const u8, request: *jetzig.Request) !jetzig.View { const timescale = try queries.entityQueryResult(request, comptime queries.loadQuery(.artist, .timescale), .{id_int}); try root.put("yearly", timescale); - const peak = try queries.entityQueryResult(request, comptime queries.loadQuery(.artist, .peak), .{id_int}); - try root.put("peak", peak); + //const peak = try queries.entityQueryResult(request, comptime queries.loadQuery(.artist, .peak), .{id_int}); + //try root.put("peak", peak); return request.render(.ok); } diff --git a/src/app/views/artists/get.zmpl b/src/app/views/artists/get.zmpl index 37a5379..89663f8 100644 --- a/src/app/views/artists/get.zmpl +++ b/src/app/views/artists/get.zmpl @@ -22,7 +22,6 @@ @else
{{.artist.scrobbles}} scrobbles ({{.artist.rank}} place)
@end -
All-time peak: {{.peak.rank}} ({{.peak.date}})
{{.artist.song_num}} songs
{{.artist.album_num}} albums
diff --git a/src/app/views/songs.zig b/src/app/views/songs.zig index f3d4bf5..72d21ce 100644 --- a/src/app/views/songs.zig +++ b/src/app/views/songs.zig @@ -60,8 +60,8 @@ pub fn get(id: []const u8, request: *jetzig.Request) !jetzig.View { const ratings = try queries.entityQueryResult(request, comptime queries.loadQuery(.song, .get_ratings), .{id_int}); try root.put("reviews", ratings); - const peak = try queries.entityQueryResult(request, comptime queries.loadQuery(.song, .peak), .{id_int}); - try root.put("peak", peak); + //const peak = try queries.entityQueryResult(request, comptime queries.loadQuery(.song, .peak), .{id_int}); + //try root.put("peak", peak); return request.render(.ok); } diff --git a/src/app/views/songs/get.zmpl b/src/app/views/songs/get.zmpl index 05e2313..a9416ce 100644 --- a/src/app/views/songs/get.zmpl +++ b/src/app/views/songs/get.zmpl @@ -30,7 +30,6 @@ @else
{{.song.scrobbles}} scrobbles ({{.song.rank}} place)
@end -
All-time peak: {{.peak.rank}} ({{.peak.date}})
@partial partials/firstlast_listens(firstlast: .firstlast)

Yearly Performance

@partial partials/timescale(range: .yearly)